Repository navigation
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel EEMD passes a bound method containing the same
RandomStateto each pool task. Workers therefore repeat noise draws: with eight trials and two processes, all eight first IMFs are identical. The parent RNG also remains unchanged. This reduces the effective ensemble and can report almost zero ensemble spread.Generate the noise in the parent and pass each draw to the worker. Ordered
imapstreams the draws without allocating the entire noise ensemble upfront and preserves the serial trial order. Update the EEMD reproducibility documentation; CEEMDAN keeps its existing guidance.Validation:
fork,spawn,forkserver, two trial counts and two worker counts. Previously only 1-5 of the requested 8 or 19 first IMFs were distinct. All 16 serial controls remain byte-identical.This validates the sampled ensemble and its reported spread, not the quality of a particular signal decomposition.