Repository navigation
remove eigen - #663
Closed
Yurlungur wants to merge 3 commits into
Closed
remove eigen#663Yurlungur wants to merge 3 commits into
Yurlungur wants to merge 3 commits into
Conversation
Yurlungur
requested review from
adamdempsey90,
buechlerm,
jdolence,
mauneyc-LANL,
pdmullen and
rbberger
October 27, 2026 11:34
Closed
Yurlungur
commented
Oct 27, 2026
| ## Current develop | ||
|
|
||
| ### Added (new features/APIs/variables/...) | ||
| - [[PR658]](https://github.com/lanl/singularity-eos/pull/XXX) Add `MinimumInternalEnergy`/`MaximumInternalEnergy` to the EOS introspection API, so energy bounds are reachable through modifiers and the `singularity::EOS` variant |
Collaborator
Author
There was a problem hiding this comment.
I noticed a bunch of URLs in the changelog that were dead. Maybe copy-pasted? Had codex fix them.
Collaborator
There was a problem hiding this comment.
That looks like something I messed up. Thanks for the cleanup.
Is using lapack too unpalatable as a fallback?
Collaborator
Author
There was a problem hiding this comment.
Nope lapack isn't too unpalatable.
Collaborator
|
Removing Eigen because of rate limiting seems a bit extreme. For GitHub CI, can't you just install the distro eigen package? |
8 of 13 tasks
Collaborator
Author
Yes---we could do that and I think that's a better solution. Superseded by #664 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
As of this month, gitlab now rate limits their users based on their subscription. Eigen is a FOSS user hosted on gitlab, and this unfortunately makes cloning Eigen from gitlab too slow to use for CI. This is causing CI failures downstream.
In singularity-eos, we use Eigen as a fallback for Kokkos-Kernels for linear algebra when Kokkos is disabled. I do believe there is some value in singularity-eos being capable of being built without Kokkos and, as recently as last year, I used Eigen to experiment with some solvers kokkos-kernels didn't provide.
However, I don't really see an acceptable path forward right now where we include Eigen in our builds. We would have to fork the code and own the fork. Even if we switched from git submodules to, e.g., spack or cmake, that would still cause us to hit the rate limits in CI unless we cached the downloaded Eigen files.
As such I'm submitting this MR where we remove Eigen from the dependencies. This should simplify the build matrix somewhat, which is good. But it does mean linear algebra (and thus solvers) only works when Kokkos is enabled.
I think if we need a CPU-only linear algebra package or we need Eigen in specific going forward, it should be relatively easy to re-enable as a one-off.
Note that upon the next release, the spackage will need to be updated. Also this is a breaking change to the API so it probably deserves a major version number bump.
@jdolence @pdmullen FYI.
@rbberger @buechlerm @adamdempsey90 please confirm you're ok with this path.
PR Checklist
make formatcommand after configuring withcmake.plan_historiesfolder, with a filename the same as the MR number.If preparing for a new release, in addition please check the following: