Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first Slovak bank, on #46's IBANs. ČSOB SK's "ČSOB Info 24 - Avízo", from tomaj/bank-mails-parser's fixtures and remp2020's raw e-mail (both MIT, 2019); samples only, so no key is pinned.
It may never verify as it stands: remp2020's e-mail carries no DKIM signature of the bank, only Gmail's ARC, and
csob.skis not DNSSEC-signed. Even with a key pinned,withDns()would refuse it. A real e-mail has to show whether ČSOB SK signs, and under which domain; the page and the class say so.BankAccount.parseIban), windows-1250 in base64 like the real e-mail; the fixture is synthetic, with a valid fake counter-party IBAN (the sample's is anonymised and fails its check digits)./VS…/SS…/KS…), text the payer wrote;NOTPROVIDEDis none. The template prints that line every time, so it is required exactly once and must follow the counter-party's name directly.utok-fantom-spravaandutok-ucet-v-sprave.Each of four guards was broken in turn and a test failed for each.
make build: green.