perf(file): reduce metadata read scheduling rounds - #9169
Draft
Ali2Arslan wants to merge 6 commits into
Draft
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Draft and stacked on #9168. After the format contract merges, rebase away its duplicated contract changes and mark this PR ready.
What this does
baseline_tail + 16 * estimated_physical_columns.max_iop_size; admitted logical ranges may still split concurrently. A zero/unbounded byte-backpressure setting conservatively uses the baseline footer path.FileSchedulersplitting into concurrent physical requests; dependency depth and physical request count remain separate concerns.I/O behavior covered by tests
FileSchedulerrequest splitting remains unconstrained by the hint planner.Validation
cargo test -p lance-filecargo test -p lance-index metadata_hint_removes_scalar_index_footer_dependencycargo test -p lance concatenates_parts_in_caller_order_without_reusing_staging_filescargo test -p lance test_hnsw_index_records_file_sizescargo test -p lance test_legacy_non_divisible_pq_searchuv run pytest python/tests/test_fragment.py::test_fragment_meta python/tests/test_commit_index.py::test_commit_index_with_files python/tests/test_table_ops.py::test_data_file_create_basic python/tests/test_table_ops.py::test_data_file_create_end_to_enduv run make lintcargo clippy --tests --manifest-path java/lance-jni/Cargo.toml -- -D warnings./mvnw -Dtest=FragmentTest,TransactionTest testcargo clippy --all --tests --benches -- -D warningsMade with Cursor