Repository navigation
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLAP rendering dereferenced
getPlayHead()unconditionally, even thoughProcessorpermits no attached clock. A processor rendered before a clock is assigned, or after detachment, could therefore crash instead of processing audio.Read the clock only when present. When no clock or position is available, continue processing with
clap_process::transport == nullptr; available transport is passed as before.A minimal test CLAP module exercises the actual provider/load/render path: it passes input audio through and reports transport presence/tempo on its other output. The regression covers initial absence, attachment, absent PositionInfo, detachment, repeated detached blocks and reattachment, checking audio continues and stale transport is not retained. No third-party plugins or audio hardware are required.
Validation: all 59 CTest suites pass on Apple Silicon macOS, RelWithDebInfo. With the original provider restored, the same regression fails with a memory access violation on the first clockless render. This branch is based independently on upstream
d0226686; no private extensions.Integration check: combined with #1211–#1215, all 63 CTest suites pass (3.63 s).