Repository navigation
Ignore unmatched image dimension end tags - #602
Open
terminalchai wants to merge 1 commit into
Open
terminalchai wants to merge 1 commit into
terminalchai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore unmatched image dimension end tags during loose parsing.
feedparser.parse("</height>")andfeedparser.parse("</width>")currently raiseTypeErrorbecausepop()returnsNonewhen there is no corresponding open element. Return immediately in the two dimension handlers when that happens. Parsing can then return its normal malformed-feed result, without inventing a zero dimension or overwriting a dimension that was already parsed.Addresses the height/width cases in #599. Other malformed-input cases in that issue are outside this change.
Add eight regression cases covering standalone end tags, stray tags inside an image, duplicate end tags following a valid dimension, and unrelated image-title text. All eight cases failed with
TypeErrorbefore the guards were added and pass afterwards. Include aFixedchangelog fragment.Validation on Windows, Python 3.11:
git diff --checkpasses.Prepared with AI assistance and reviewed against the report, existing parser behavior, and regression results.