Skip to content

Add optional exec websocket keepalive with lifecycle safeguards - #3066

Merged
kubernetes-prow[bot] merged 2 commits into
kubernetes-client:mainfrom
davidgamero:exec-keepalive-feedback
Sep 24, 2026
Merged

kubernetes-prow[bot] merged 2 commits into
kubernetes-client:mainfrom
davidgamero:exec-keepalive-feedback

Conversation

@davidgamero

@davidgamero davidgamero commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

reimplements #2878 with its review feedback

changes on top of 2878

  • validate intervals before connecting so invalid options cannot start a remote command
  • reject oversized intervals
  • skip keepalive unless the socket is open and supports ping and listener registration/removal
  • remove all keepalive listeners on close/error and stop the timer if the socket is no longer open
  • unref the timer so it cannot keep node running
  • replace sleep-based coverage with deterministic timer tests and add a real websocket ping/pong test

ai disclosure: opencode and gpt6

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2026
@kubernetes-prow kubernetes-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 23, 2026
@davidgamero
davidgamero marked this pull request as ready for review September 24, 2026 02:59
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from cjihrig September 24, 2026 02:59
@brendandburns

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, davidgamero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,davidgamero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot merged commit 9c29664 into kubernetes-client:main Sep 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants