Repository navigation
Conversation
Signed-off-by: sabnaj <sabnaj@appscode.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Visit the preview URL for this PR (updated for commit a9fcb61): https://kubedb-v2-hugo--pr1088-milvus-object-storag-gv5zkd4v.web.app (expires Thu, 12 Nov 2026 12:09:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0f29ae8ae0bd54a99bf2b223b6833be47acd5943 |
Use milvuses.kubedb.com, wait for pods to exist, replace the Service selector, note slow rollback, dead pods and the second Milvus on one Secret. Signed-off-by: sabnaj <sabnaj@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new Milvus has an empty etcd. On an object storage path that still holds another cluster's write-ahead logs, log ids restart, the old logs fence the writer, and writes time out while the status looks healthy. The operator never looked at S3, and the default path is
filesfor every Milvus in a bucket.Before the first pod starts, the operator counts the keys of the meta etcd. If there are none, a Job runs
milvus-archiver storage-checkagainst the renderedmilvus.yaml.ObjectStorageChecked=False, reasonPathInUse, names the bucket and path. It rechecks every minute and starts by itself once the path is free.kubedb.com/milvus-skip-object-storage-check: "true"skips it.WipeOut still never deletes object storage, the same as the official Milvus operator.
Stacked on
milvus-inplace-adoption; merge that first.