Repository navigation
Remove the unused OpenAI and ImGui.NET packages and the no-op AI menu items [patch] - #517
Merged
Merged
Conversation
… items [patch] The OpenAI feature was commented out long ago, but its package, its token field in the plain-text options file and two empty "Generate Tests" / "Generate Documentation Comments" menu items on .cs files remained. ImGui.NET was never referenced; the app uses Hexa.NET.ImGui, so it only shipped a second, conflicting native cimgui. Fixes #447 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW5526rrxQXBzaZBBJE
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW5526rrxQXBzaZBBJE
|
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #447
What changed
OpenAIandImGui.NETfromProjectDirector.csprojandDirectory.Packages.props. Both entries are removed together, as KTSU0005 requires.ChatClientcode, and the right-click "Generate Tests" / "Generate Documentation Comments" items on.csfiles. Both items had empty bodies. The menu now offers only actions that do something.OpenAIToken(the property and its semantic type) fromProjectDirectorOptions. An old settings file that still has the field loads fine; the unknown property is ignored.Tests
New
UnusedDependencyTests:OptionsHaveNoOpenAITokenFieldchecks that the options type has noOpenAITokenproperty.UnusedPackageIsNotShipped("OpenAI.dll" / "ImGui.NET.dll")checks that neither assembly reaches the build output.With the source changes reverted, all three fail. With them applied, all three pass.
The full suite, from a clean build: 181 passed, 1 skipped, 1 failed. The failure is
GitCliTests.CloningAnLfsRepositoryRestoresTheFileContentRatherThanThePointer, and it fails the same way on unmodifiedmainin this container. It is an environment issue (LFS smudge through the sandbox proxy), not this change. The whole solution,tests/ProjectDirector.UITestsincluded, builds with 0 warnings.Generated by Claude Code