Repository navigation
Regenerate CompatibilitySuppressions.xml after the Polyfill 11.4.5 bump [patch] - #89
Open
matt-edmondson wants to merge 1 commit into
Open
matt-edmondson wants to merge 1 commit into
matt-edmondson wants to merge 1 commit into
Conversation
…mp [patch] Polyfill 11.4.5 changed which shim members are emitted per target framework, so 270 of the 281 suppressions no longer match anything (133 of them CP0016 nullable-metadata entries between net7.0 and net8.0, the rest CP0001/CP0002/ CP0008/CP0014/CP0015 entries across the other TFM pairs). Package validation reported them as "Unnecessary suppressions found" and failed the Release step; the ~800 errors in the CI log are that list printed three times, not new API diffs. Regenerated with -p:ApiCompatGenerateSuppressionFile=true; the change only deletes entries, and the 11 that remain are unchanged. Fixes #86 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW5SEp6KyM6e9r7Pa7H
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #86
What changed
Invoker/CompatibilitySuppressions.xmlwas regenerated with-p:ApiCompatGenerateSuppressionFile=trueagainst the pinned ktsu.Sdk. There is no code change.The ~800 errors in the scheduled CI log (444 × CP0016, 216 × CP0001 and so on) are the "Unnecessary suppressions found" list, printed three times. The log has no
error CPxxxx: Cannot …lines, so there are no new API diffs. The triage note asked whether the TFM set had changed. It hasn't: the stale entries cover the same net5.0–net10.0 and netstandard pairs the SDK still builds.Verification
Run locally on SDK 10.0.403:
main: fails with "Unnecessary suppressions found", the same failure as the Release job.bin/obj: exit 0. It producesktsu.Invoker.1.4.5-pre.1.nupkgand.snupkg.dotnet test --project Invoker.Test: 40 passed, 0 failed.Once this merges, the open Invoker PRs (#87, #88) can ship when they land.
Generated by Claude Code