Repository navigation
Skip Finder's Icon\r folder-icon file instead of failing it [patch] - #164
Open
matt-edmondson wants to merge 3 commits into
Open
matt-edmondson wants to merge 3 commits into
matt-edmondson wants to merge 3 commits into
Conversation
Finder writes an empty "Icon\r" file when a folder gets a custom icon. It was decoded as an input, failed, and made an otherwise clean batch exit 2. IsFileManagerMetadata now skips it alongside .DS_Store and desktop.ini. Fixes #163 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW4hvLssY2rDFbS3wDM
3.1.12 carries GHSA-v76p-62qx-wwq2, and NuGet audit warnings are errors, so restore fails on main and on every PR. Ported from #145. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW4hvLssY2rDFbS3wDM
Contributor
Author
|
This PR's CI is red because of
To unblock
The tests for this change pass locally on 3.1.12 with the audit turned off: 90 passed, 0 failed. Generated by Claude Code |
… license 3.2.0 is the only release that fixes GHSA-v76p-62qx-wwq2, but its build targets fail any CI build that has no SixLaborsLicenseKey. Picking a license, an audit suppression or another library is a maintainer decision, so this PR goes back to main's dependency set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW4hvLssY2rDFbS3wDM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163
What changed
IsFileManagerMetadatanow skips Finder's custom-folder-icon file,"Icon\r"(an empty data fork; the icon is in the resource fork). Before, it was decoded, failed withUnknownImageFormatException, and made an otherwise clean batch exit 2. The match is ordinal and exact, so a plainIconfile, or one that differs in case, is still treated as an input.Tests
TreatsFindersCustomFolderIconFileAsMetadata: unit check onIsFileManagerMetadata, cross-platform.SkipsFindersCustomFolderIconFileWithoutCountingItAsFailed: a batch holdingstar.pngplus an emptyIcon\rreturnsBatchResult(1, 0)and exit 0. Windows can't create a file name containing CR, so this one reports Inconclusive there.Both tests fail with the fix reverted and pass with it in place. The full suite passes on Linux: 90 passed, 0 failed.
Note: restore on
maincurrently fails locally with NU1903, because SixLabors.ImageSharp 3.1.12 has a high-severity advisory. #145 bumps it. I ran the suite with-p:NuGetAudit=false.Generated by Claude Code