Repository navigation
Escape the branch name in GitHub branch URLs [patch] - #387
Merged
Merged
Conversation
Open Branch URL and Copy Branch URL interpolated the raw branch name, so fix/#123-crash became a /fix/ link with a #123-crash fragment and a % read as a percent-escape. Escape each segment and keep the / separators. Fixes #386 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW2nrCvY4DyoEF72Nk1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #386
What was wrong
GetBranchUrlput the raw branch name into the URL. Forfix/#123-crash, "Open Branch URL" and "Copy Branch URL" produced…/tree/fix/#123-crash, which a browser reads as path/tree/fix/plus the fragment#123-crash. A%in a branch name was read as a percent-escape.Change
GetBranchUrlescapes each/-separated segment withUri.EscapeDataStringand keeps the separators. It is nowinternalso it can be tested.BranchUrlTestspins the cases from the issue:fix/#123-crashgives…/tree/fix/%23123-crash,feature/50%gives…/tree/feature/50%25, and plainfeature/fooandmainare unchanged.Verification
#and%cases fail and the plain cases pass. With the fix, all four pass.dotnet test --project BuildMonitor.Test: 147/147 pass.dotnet build -c Release: 0 warnings.Generated by Claude Code