Repository navigation
Colour canceled runs dark gray instead of failure red [patch] - #368
Merged
Merged
Conversation
GetStatusColor painted RunStatus.Canceled with the same red as Failure, so the Status column could not tell a canceled run from a failed one. Canceled now gets Palette.Neutral.DarkGray, distinct from both Failure (red) and Pending (gray), matching the History column's view that a cancellation is not a failure. Fixes #363 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GKJwMybTmY6x4mJfMM9RKv
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #363
What changed
GetStatusColormappedRunStatus.CanceledtoPalette.Basic.Red, the same colour asRunStatus.Failure. So in the Status column a canceled run looked exactly like a failed one.Canceled now uses
Palette.Neutral.DarkGray. That keeps it apart from Failure (red) and from Pending (Palette.Neutral.Gray). It also matches the History column, which already filters out cancellations instead of treating them as failures.The issue left the colour as a design call. I picked a neutral one because it was the issue's first suggestion and fits the History column. Changing it later is a one-line edit.
GetStatusColoris nowinternal, so the new tests can call it.Tests
StatusColorTests: canceled ≠ failure and canceled ≠ pending.Palette.Basic.Redmapping and passes with the fix.BuildMonitor.Test: 140/140 pass.tests/BuildMonitor.UITests: 6/6 pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01GKJwMybTmY6x4mJfMM9RKv
Generated by Claude Code