[matt-edmondson]

Why

After the Polyfill 11.4.5 bump, dotnet pack fails package validation on main. Reproduced locally with 229 errors:

• 136 × CP0016
• 64 × CP0001
• 24 × CP0002
• 5 × CP0008

Every one is on a polyfilled BCL type. This is why 1.18.2 is still the latest release, and why #348, #349 and #350 never shipped.

Change

• Regenerated AppDataStorage/CompatibilitySuppressions.xml with -p:ApiCompatGenerateSuppressionFile=true.
• The file drops from 241 entries to 12:
  • 10 × CP0014 and 1 × CP0015, all on Polyfill shim types.
  • 1 × CP0002 on AppData<T>.get_Lock (net8.0 → net9.0). The old file already had this one, and it is intentional: Lock is an object before net9.0 and a System.Threading.Lock from net9.0.
• The triage asked whether net10.0 is covered: 9 of the entries are net9.0 → net10.0 pairs, and pack now succeeds on every target framework.

Verification

• Before: dotnet pack AppDataStorage -c Release fails with the errors above.
• After, from a clean bin/obj: pack succeeds and writes ktsu.AppDataStorage.1.19.0.nupkg.
• dotnet test: 120 passed, 0 failed.

Fixes #358

---

Generated by Claude Code

[matt-edmondson]

ci / .NET / Test on macos-latest is red, but this change didn't cause it. The job built the package and passed all 120 tests. It then failed in setup-dotnet's post-job cleanup, after testing had finished: The 'dotnet nuget locals all --list --force-english-output' command failed with exit code: 137, which means the runner killed that process. Nothing in this PR touches that step, and it has no fix to port. I'll re-run the failed job once the workflow finishes.

---

Generated by Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud