Conversation
Three separate issues: * Metal has no static storage duration inside a function, so MatRepSymGPU::off() drops the static on its offset table. Nothing is lost by dropping it everywhere rather than forking: arrays, unlike scalars, are emitted into read-only data either way. On the host it is marginally better, since the static form reached the table through the GOT. * operator=(Expr) now takes the expression by value. MSL folds the address space into a deduced parameter, so the generic operator=(const M&) deduced M = thread Expr<...>, matched exactly, beat the Expr overload and then tried mRep = rhs.mRep on an expression. A by-value parameter has no address space to deduce, so the Expr overload wins on Metal as it already did elsewhere. Expr is two references, so there is no copy cost. * Metal supports up to C++17, so it needs the same treatment as OpenCL for a requires-clause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your PR AliceO2Group#15826 cannot be merged as is. You should either run
clang-formatyourself and update the pull request, or merge this PR in yours.You can find the AliceO2 coding conventions at https://github.com/AliceO2Group/CodingGuidelines.