Repository navigation
Fix/dependabot alerts - #153
Merged
Merged
Conversation
Resolve the Dependabot alerts for undici and @fastify/busboy. - @actions/core 1.11.1 -> 3.0.1, @actions/exec 1.1.1 -> 3.0.0, @actions/glob 0.4.0 -> 0.6.1 - undici 5.29.0 and @fastify/busboy 2.1.1 came in via @actions/core 1.x (@actions/http-client 2.x). undici 5.x has no patched release, so the old @actions/core is dropped from the tree. - undici 6.25.0 -> 6.29.1 (lockfile update within ^6.23.0 of @actions/http-client 4.0.1) The minimatch alert (GHSA-g3hv-75wg-m249) remains: the only fix is 11.0.1, which @actions/glob cannot use yet.
… and @actions/glob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves 22 of the 23 open Dependabot alerts: undici (20) and @fastify/busboy (2). The minimatch alert remains.
Changes
@actions/core1.11.1 → 3.0.1. This drops the path through@actions/http-client2.x that brought in undici 5.29.0 and @fastify/busboy 2.1.1. No undici 5.x release fixes these alerts.@actions/glob0.4.0 → 0.6.1, since 0.4.0 depends on@actions/core1.x. 0.6.1 is the version@actions/cachealready uses, and it keeps minimatch 3.1.5.@actions/exec1.1.1 → 3.0.0 to match the version@actions/cacheand@actions/tool-cachealready use.^6.23.0of@actions/http-client4.0.1).dist/. Duplicate copies of core, undici and glob are gone, anddist/index.jsdrops from 5096 kB to 3124 kB (as reported by ncc).The upgraded packages are ESM-only. The ncc build already handles that, since
@actions/cache6 and@actions/tool-cache4 are ESM-only too. No source changes were needed.In
@actions/http-client, undici is only used forProxyAgentingetAgentDispatcher(). Neither this action nor its dependencies call it.Not addressed: minimatch (GHSA-g3hv-75wg-m249)
The only patched version is 11.0.1. The minimatch 11 changelog lists the removal of
Minimatch#matchOne(), which@actions/globstill calls as of 0.7.0, so overriding minimatch to 11.x would be incompatible. minimatch 3.1.5 used here does not contain the vulnerable code (firstPhasePreProcess, reached only withoptimizationLevel >= 2).Verification
cache-dependency-path). TheGITHUB_PATH,GITHUB_ENVandGITHUB_STATEcontents and the cache key were identical.