Repository navigation
Use 64 bit archive for haxe 3.4.4+ on windows - #147
Conversation
krdlab
left a comment
krdlab
left a comment
There was a problem hiding this comment.
Thanks for the follow-up. Splitting the arch check per tool makes sense, and dropping the Haxe 3 override simplifies HaxeAsset.
CI and CodeQL are green, including Haxe 3.4.7 on windows-latest and windows-11-arm. Both jobs fetched haxe-3.4.7-win64.zip with neko-2.3.0-win.zip, then passed haxelib install and the test compilation.
One request before merge: please add the supported Haxe 3 range to the README. On Windows, win64 archives only exist from 3.4.4 on, so 3.4.3 and earlier will now fail with a 404. I've left a suggestion on the new note.
Thanks for spotting that, I didn't consider the fact that this might break other versions. I think in that case I will make the change more fine-grained to only use 64-bit for supported versions, otherwise this would be a breaking change |
We need to install 32-bit neko for haxelib to work with the haxe 3 package, but for haxe we can use the 64-bit binary for 3.4.4+.
Haxe 3.4.3 was the last version that was missing a 64-bit windows build, so make sure that is still resolving to 32-bit.
d2b86af to
6ff1cbc
Compare
tobil4sk
changed the title
krdlab
left a comment
krdlab
left a comment
There was a problem hiding this comment.
Thanks for reworking this. The 3.4.4 cutoff avoids the breaking change, so I've withdrawn the README suggestion.
CI and CodeQL are green on the new head.
As mentioned in #138 (comment), only neko has to be 32-bit for haxe 3 installs here, not haxe itself.