Skip to content

fix(krmvalidate): skip DirectSubpackages on .krmignore-excluded dirs - #4877

Closed
SurbhiAgarwal1 wants to merge 38 commits into
kptdev:mainfrom
SurbhiAgarwal1:fix/4868-krmignore-ignored-subpkg
Closed

SurbhiAgarwal1 wants to merge 38 commits into
kptdev:mainfrom
SurbhiAgarwal1:fix/4868-krmignore-ignored-subpkg

Conversation

@SurbhiAgarwal1

Copy link
Copy Markdown
Contributor

Description

In pkg/lib/krmvalidate/prescan.go:

  • scanTree (when honorKrmignore is true, used by kpt fn eval and kpt fn source): Load reachableKptfileDirs upfront at the package root before any DirectSubpackages() call. When reachable is non-nil, skip DirectSubpackages() and instantiate only the reachable subpackages via pkg.New.
  • collectOptedIn (used by kpt live pre-scan): Load reachableKptfileDirs upfront with flat root-only .krmignore semantics (packageFileName = "") and instantiate only reachable subpackages, falling back to DirectSubpackages() only if reachableKptfileDirs returns nil on a read error.
  • Tests: Added TestScanIgnoredSubpackageUnreadableKptfile in pkg/lib/krmvalidate/prescan_test.go covering .krmignore-excluded subpackages containing v1alpha1, invalid YAML, unknown-field, or empty Kptfiles, as well as negative cases for unignored subpackages.

Motivation

Previously, both scanTree and collectOptedIn called p.DirectSubpackages() before filtering out .krmignore-excluded paths. Because DirectSubpackages() delegates to pkg.Subpackages(), which walks the directory tree and calls kptfileutil.ReadKptfile on every Kptfile it encounters, having an unreadable, v1alpha1, unknown-field, or empty Kptfile inside an ignored directory (such as a testdata/fixture/ directory excluded by .krmignore) caused kpt fn eval, kpt fn source, and kpt live init to fail immediately during the pre-scan. Resolving reachable package directories via kio.LocalPackageReader upfront ensures .krmignore is honored before any Kptfile parsing occurs, while preserving existing error reporting for non-ignored subpackages.

Fixes #4868

Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
… in Kptfile status

Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…les containing offending documents'

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
… the root package)

Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…ring out-of-place renders)

Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…en classifying parsed files)

Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…consistent across merge paths)

Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
… without inheritance)

Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
… discovery and attribution)

Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
… during destination writes)

Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…on input and output checks)

Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…e merge rebase

Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…g root not relative paths

Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…reader

Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…t .krmignore

Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: SurbhiAgarwal <agarwalsurbhi1807@gmail.com>
@SurbhiAgarwal1
SurbhiAgarwal1 requested review from a team November 17, 2026 17:08
Copilot AI balanced review requested due to automatic review settings November 17, 2026 17:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@netlify

netlify Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for kptdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit da807dd
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/6afc8a29e18129fb252c3e4a
😎 Deploy Preview https://deploy-preview-4877--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@SurbhiAgarwal1
SurbhiAgarwal1 deleted the fix/4868-krmignore-ignored-subpkg branch November 17, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kpt fn eval .krmignore handling errors out when different api versions in parent/subpkg

3 participants