Repository navigation
fix(krmvalidate): skip DirectSubpackages on .krmignore-excluded dirs - #4877
Closed
SurbhiAgarwal1 wants to merge 38 commits into
Closed
SurbhiAgarwal1 wants to merge 38 commits into
SurbhiAgarwal1 wants to merge 38 commits into
Conversation
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
… in Kptfile status Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…les containing offending documents' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
… the root package) Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…ring out-of-place renders) Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…en classifying parsed files) Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…consistent across merge paths) Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
… without inheritance) Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
… discovery and attribution) Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
… during destination writes) Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…on input and output checks) Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…e merge rebase Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…g root not relative paths Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…reader Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…t .krmignore Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: SurbhiAgarwal <agarwalsurbhi1807@gmail.com>
SurbhiAgarwal1
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
November 17, 2026 17:08
✅ Deploy Preview for kptdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
pkg/lib/krmvalidate/prescan.go:scanTree(whenhonorKrmignoreistrue, used bykpt fn evalandkpt fn source): LoadreachableKptfileDirsupfront at the package root before anyDirectSubpackages()call. Whenreachableis non-nil, skipDirectSubpackages()and instantiate only the reachable subpackages viapkg.New.collectOptedIn(used bykpt livepre-scan): LoadreachableKptfileDirsupfront with flat root-only.krmignoresemantics (packageFileName = "") and instantiate only reachable subpackages, falling back toDirectSubpackages()only ifreachableKptfileDirsreturnsnilon a read error.TestScanIgnoredSubpackageUnreadableKptfileinpkg/lib/krmvalidate/prescan_test.gocovering.krmignore-excluded subpackages containingv1alpha1, invalid YAML, unknown-field, or emptyKptfiles, as well as negative cases for unignored subpackages.Motivation
Previously, both
scanTreeandcollectOptedIncalledp.DirectSubpackages()before filtering out.krmignore-excluded paths. BecauseDirectSubpackages()delegates topkg.Subpackages(), which walks the directory tree and callskptfileutil.ReadKptfileon everyKptfileit encounters, having an unreadable,v1alpha1, unknown-field, or emptyKptfileinside an ignored directory (such as atestdata/fixture/directory excluded by.krmignore) causedkpt fn eval,kpt fn source, andkpt live initto fail immediately during the pre-scan. Resolving reachable package directories viakio.LocalPackageReaderupfront ensures.krmignoreis honored before anyKptfileparsing occurs, while preserving existing error reporting for non-ignored subpackages.Fixes #4868