Skip to content

Upgrade golangci-lint to 2.15.0 - #4875

Merged
liamfallon merged 2 commits into
kptdev:mainfrom
Nordix:upgrade-golangci-lint-2.15.0-20261113
Nov 13, 2026
Merged

liamfallon merged 2 commits into
kptdev:mainfrom
Nordix:upgrade-golangci-lint-2.15.0-20261113

Conversation

@aravindtga

@aravindtga aravindtga commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • golangci-lint version bumped to 2.15.0
  • All modules verified (go mod tidy, go fmt, go vet, go build)
  • CI fixed to trigger build on linter changes and make files

AI Disclosure

  • I have used AI in the creation of this PR.

Automated via go-upgrade script (AI-assisted development).

@netlify

netlify Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for kptdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 47c38b1
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/6af70ee1a4af656bcb9060e6
😎 Deploy Preview https://deploy-preview-4875--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

- golangci-lint version bumped to `2.15.0`
- All modules verified (go mod tidy, go fmt, go vet, go build)

Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
@aravindtga
aravindtga force-pushed the upgrade-golangci-lint-2.15.0-20261113 branch from 037b4b1 to 4e3e491 Compare November 13, 2026 13:10
@aravindtga
aravindtga requested a balanced review from Copilot November 13, 2026 13:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review has no active issues requiring resolution.

No open issues 🎉

What changed in this PR

Upgrades kpt’s golangci-lint target to 2.15.0 and replaces repeated string literals with shared constants, preserving existing behavior.

Changes:

  • Updates the linter version in build settings, upgrade automation, and documentation.
  • Introduces shared constants for inventory fields, function types, and live-plan diff types.
File Description
scripts/​go-upgrade/​README.md Updates the documented linter target to 2.15.0.
scripts/​go-upgrade/​config.env Sets the upgrade script’s linter target to 2.15.0.
pkg/​live/​load.go Uses shared inventory field constants.
pkg/​live/​inventoryrg.go Defines and uses inventory field constants.
make/​info.mk Bumps the build’s linter version to 2.15.0.
cli/​fn/​cmdeval/​cmdeval.go Reuses function-type constants in completion, saving, and validation.
cli/​alpha/​live/​plan/​diff.go Defines and uses diff-type constants.
cli/​alpha/​live/​plan/​command.go Uses diff-type constants when formatting plan output.

Review effort: Balanced

Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
@aravindtga
aravindtga marked this pull request as ready for review November 13, 2026 13:29
@aravindtga
aravindtga requested review from a team November 13, 2026 13:29
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
47.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@liamfallon
liamfallon merged commit edc5f4d into kptdev:main Nov 13, 2026
27 checks passed
Comment thread pkg/live/inventoryrg.go Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants