Repository navigation
patch adding version specifying + older binary handling for kpt&go install … - #4871
Merged
liamfallon merged 2 commits intoNov 18, 2026
Merged
Conversation
…github action Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Catalin-Stratulat-Ericsson
requested review from
a team
and
a balanced review from Copilot
November 12, 2026 18:31
Catalin-Stratulat-Ericsson
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
November 12, 2026 18:31
✅ Deploy Preview for kptdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the kpt version-selection and release-tag updates.
No open issues 🎉
What changed in this PR
Updates the shared Go/kpt setup action to support explicit kpt versions and older release tags while retaining version resolution from go.mod.
Changes:
- Adds a
kpt-versioninput that overrides the version file and accepts versions without avprefix. - Checks for a
cli/<version>release, falls back to<version>on HTTP 404, and fails on unexpected responses. - Passes the resolved tag to the existing release installer.
| File | Description |
|---|---|
.github/actions/setup-go-kpt/action.yml |
Adds explicit version selection and release-tag detection for newer and older kpt binaries. |
Review effort: Balanced
4 tasks done
aravindtga
reviewed
Nov 13, 2026
aravindtga
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this PR. Added one suggestion.
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
aravindtga
approved these changes
Nov 13, 2026
liamfallon
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the "Go/Kpt install" GitHub action such that the user can specify version rather than just go.mod only + it can now work with older kpt binaries that dont use the
cli/<tag>pathing.This was requested by @aravindtga here https://github.com/kptdev/porch/pull/1362/changes#r4538904676
And this is also required to be merged before kptdev/porch#1362 to operate as intended
What the action does now