Skip to content

Build impersonated client without the shared cache #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ArnobKumarSaha wants to merge 1 commit into from
Closed

Build impersonated client without the shared cache #652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions client/delegated.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,11 @@ func (d *DelegatingClient) Impersonate(u user.Info) (*restclient.Config, client.

// share the transport between all clients
optionsShallowCopy := d.options
// The shared cache is populated with the base client's credentials, so serving an
// impersonated read from it would skip the impersonated user's authorization. Drop it
// here: the impersonated client reads directly from the API with the impersonation
// headers set on config above.
optionsShallowCopy.Cache = nil
if d.options.HTTPClient != nil {
optionsShallowCopy.HTTPClient = &http.Client{
Transport: transport.NewImpersonatingRoundTripper(transport.ImpersonationConfig{
Expand Down Expand Up @@ -186,6 +191,9 @@ type delegatingReader struct {
}

func (d *delegatingReader) shouldBypassCache(obj runtime.Object) (bool, error) {
if d.CacheReader == nil {
return true, nil
}
gvk, err := apiutil.GVKForObject(obj, d.scheme)
if err != nil {
return false, err
Expand Down
Loading