Repository navigation
KZN-18921 - Harden the expression worker - #51
Merged
Merged
Conversation
…rors, and timeouts
There was a problem hiding this comment.
🟡 Changes recommended
Error handling still permits sensitive diagnostic exposure, and nullable failures conflict with public return types and field visibility behavior.
3 open issues
What changed in this PR
This PR hardens expression evaluation by handling worker failures and bounding execution time while preserving diagnostic details in debug mode.
Changes:
- Extracts evaluation logic and returns structured errors for parsing, evaluation, and serialization failures.
- Adds a 20-second timeout, worker cleanup, and host-side error handling.
- Adds tests for failure handling, diagnostics, and worker lifecycle behavior.
| File | Description |
|---|---|
src/workers/expression.worker.ts |
Delegates messages to the response builder. |
src/workers/expression.ts |
Adds guarded evaluation and error categorization. |
src/workers/expression.test.ts |
Tests evaluation, invalid inputs, serialization, and diagnostics. |
src/run.ts |
Adds timeouts, cleanup, and failure handling. |
src/run.test.ts |
Tests worker lifecycle and host-side failure behavior. |
Review effort: Balanced
keegandonley
requested review from
mauricebecnel400
and
a balanced review from Copilot
October 26, 2026 16:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Protect against exceptions, parse errors, and timeouts.
Jira: https://kizen.atlassian.net/browse/KZN-18921