Repository navigation
fix(ci): support exact Node.js security versions - #53
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 22, 2026
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40e011bea3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Coverage Report
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared workflows declare
node-versionas a number, so an exact security pin such as22.23.4fails GitHub workflow validation before jobs start. Add optional stringnode-version-specto build/lint/test and quality, taking precedence over the existing numeric input. Existing numeric callers remain compatible.Use the effective version for setup and cache identity. Upload coverage from the matching matrix entry, or the first entry when an exact setup pin is absent from a major-version matrix; this prevents the coverage job from missing its artifact. Add a patch changeset.
Validation: local YAML parsing, runtime-selection contract checks, Changesets status and diff checks pass. Hosted regression checks pass for exact runtime, precedence over a conflicting legacy major, legacy numeric compatibility, quality/changesets, and coverage artifact upload/download from a numeric test matrix. The coverage fixture generates explicitly synthetic empty reports to exercise artifact handling. Run: https://github.com/kethalia/workflows/actions/runs/39821985818.
Active consumers Hive #347, lsp-indexer #405 and ChillPass #271 pin commit
308b2ca0ac2ae4b499cdf9883e4b21910e4c8822while the shared release is pending. No release tag moved.GitHub's input-type contract: https://docs.github.com/en/actions/how-tos/reuse-automations/reuse-workflows#passing-inputs-and-secrets-to-a-reusable-workflow