Skip to content

fix(ci): support exact Node.js security versions - #53

Merged
b00ste merged 3 commits into
mainfrom
codex/exact-node-runtime
Oct 22, 2026
Merged

b00ste merged 3 commits into
mainfrom
codex/exact-node-runtime

Conversation

@b00ste

@b00ste b00ste commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

The shared workflows declare node-version as a number, so an exact security pin such as 22.23.4 fails GitHub workflow validation before jobs start. Add optional string node-version-spec to build/lint/test and quality, taking precedence over the existing numeric input. Existing numeric callers remain compatible.

Use the effective version for setup and cache identity. Upload coverage from the matching matrix entry, or the first entry when an exact setup pin is absent from a major-version matrix; this prevents the coverage job from missing its artifact. Add a patch changeset.

Validation: local YAML parsing, runtime-selection contract checks, Changesets status and diff checks pass. Hosted regression checks pass for exact runtime, precedence over a conflicting legacy major, legacy numeric compatibility, quality/changesets, and coverage artifact upload/download from a numeric test matrix. The coverage fixture generates explicitly synthetic empty reports to exercise artifact handling. Run: https://github.com/kethalia/workflows/actions/runs/39821985818.

Active consumers Hive #347, lsp-indexer #405 and ChillPass #271 pin commit 308b2ca0ac2ae4b499cdf9883e4b21910e4c8822 while the shared release is pending. No release tag moved.

GitHub's input-type contract: https://docs.github.com/en/actions/how-tos/reuse-automations/reuse-workflows#passing-inputs-and-secrets-to-a-reusable-workflow

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T17:20:50.146203Z afc74e5 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 40e011bea3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 100% 0 / 0
🔵 Statements 100% 0 / 0
🔵 Functions 100% 0 / 0
🔵 Branches 100% 0 / 0
File CoverageNo changed files found.
Generated in workflow #3 for commit 308b2ca by the Vitest Coverage Report Action

@b00ste
b00ste merged commit 6854163 into main Oct 22, 2026
23 checks passed
@b00ste
b00ste deleted the codex/exact-node-runtime branch October 22, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant