Repository navigation
Conversation
troglobit
requested changes
Oct 8, 2026
troglobit
left a comment
troglobit
left a comment
Contributor
There was a problem hiding this comment.
Minor comments, mostly for internal discussion.
Comment on lines
+444
to
+447
| deviation "/rt:routing/rt:control-plane-protocols/rt:control-plane-protocol/ospf:ospf/ospf:auto-cost/ospf:reference-bandwidth" { | ||
| deviate add { | ||
| default "100000"; | ||
| } |
Contributor
There was a problem hiding this comment.
This needs the eyes of an expert, @jovatn how will this affect existing Styx installations?
Contributor
There was a problem hiding this comment.
Ah, I see now that the default is the same as the previous hard-coded value in Frr. So less critical, but maybe we should change the default? What do you think @jovatn ...
Contributor
There was a problem hiding this comment.
I'm a bit in a hurry now, but lets discuss next week if you think we should change.
We have not discussed this, but my main intention was to use FRR defaults as Infix defaults (see initial description)
- Then we should not need migration scripts
- And I believe that 100Gbit/s is a better reference bandwidth for the future than 100Mbit/s (or whatever the standard may say).
Still, it is wise to lookup existing styx installations, although I believe/hope that adjustments (if needed) be done on appropriate repo than on mainline Infix.
saba8814
force-pushed
the
add-support-for-ospf-auto-cost-configuration
branch
2 times, most recently
from
October 8, 2026 15:57
5edf54b to
22355ea
Compare
All routers in an OSPF domain must use the same reference bandwidth to agree on link costs, and other vendors default to other values than Frr. Until now the value was fixed at the Frr default. Enable the ietf-ospf auto-cost feature for OSPFv2 and OSPFv3. The reference-bandwidth leaf defaults to 100000 Mbit/s, the value used so far, so link costs do not change on upgrade and no migration is needed. Frr can not turn auto-cost off, so the enabled leaf defaults to true and false is rejected. Resolves: #1576 Signed-off-by: Ejub Sabic <ejub1946@outlook.com>
To check that the reference bandwidth matches across the domain it has to be readable. Frr has no JSON for it, so read it from the daemon's running-config, which lists it only when it differs from the default. Report it for OSPFv2 and OSPFv3, and show it in 'show ip ospf' and 'show ipv6 ospf'. Signed-off-by: Ejub Sabic <ejub1946@outlook.com>
Verify that the interface cost follows the reference bandwidth, for OSPFv2 and OSPFv3. The expected cost is derived from the link speed, so the test works on hardware and on virtual links of unknown speed. On a 1 Gbit/s link the reference bandwidths 100000, 10000 and 1000 Mbit/s give the costs 100, 10 and 1. Signed-off-by: Ejub Sabic <ejub1946@outlook.com>
Explain why the reference bandwidth must match across the domain, how the interface cost is calculated, and where to read the value. Signed-off-by: Ejub Sabic <ejub1946@outlook.com>
saba8814
force-pushed
the
add-support-for-ospf-auto-cost-configuration
branch
from
October 8, 2026 16:06
22355ea to
a46aefa
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All OSPF routers in a domain need the same auto-cost reference bandwidth
to agree on link costs. Other vendors use other defaults than Frr, so
the value has to be configurable. Resolves #1576.
The
auto-costcontainer from ietf-ospf is now supported, for OSPFv2and OSPFv3:
reference-bandwidthdefaults to 100000 Mbit/s, the Frr default usedso far. Link costs do not change on upgrade, so no migration script
is needed.
enabledis always true. Frr has no way to turn auto-cost off, sosetting it to false is rejected. An explicit interface
coststilloverrides the calculated one.
shown by
show ip ospfandshow ipv6 ospf.The new test
ospf_auto_costruns for both OSPF versions. It sets thereference bandwidth on both routers and checks the interface cost. On
a 1 Gbit/s link, 100000, 10000 and 1000 Mbit/s give the costs 100, 10
and 1.
Checklist
Tick relevant boxes, this PR is-a or has-a: