Repository navigation
Raise the Claude SDK message buffer to 32 MB - #150
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b660687585
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| personal chrome-devtools server) out of rae's sessions, so the agent only sees | ||
| the browser and tools rae registers. | ||
| """ | ||
| return {"strict_mcp_config": True, "max_buffer_size": SDK_MAX_BUFFER_SIZE} |
There was a problem hiding this comment.
Raise the SDK minimum before passing strict_mcp_config
For installations retaining claude-agent-sdk==0.1.48, which still satisfies the dependency declared in pyproject.toml, every call using this helper raises TypeError: ClaudeAgentOptions.__init__() got an unexpected keyword argument 'strict_mcp_config'. The 0.1.48 options definition has no such field. This prevents Claude auto, engineer, and collector sessions from starting, even though testing against the newer locked SDK succeeds. Raise the declared SDK minimum to a version supporting this option, or pass the isolation flag through the older SDK's supported extra_args mechanism.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
1 issue found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="CHANGELOG.md">
<violation number="1" location="CHANGELOG.md:18">
P3: `provider rae configured` is grammatically ambiguous and inconsistent with the changelog’s `RAE` branding. Change it to `the provider configured by RAE`.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
|
||
| ### Fixed | ||
| - Playwright MCP prompt: `browser_run_code` is now `browser_run_code_unsafe`, and the nonexistent `browser_scroll` tool is no longer listed. | ||
| - Claude SDK sessions no longer load the user's own Claude Code MCP servers (`strict_mcp_config`), so a personal browser MCP such as chrome-devtools can no longer replace the provider rae configured, and the message buffer is raised to 32 MB so a large screenshot no longer aborts a run. |
There was a problem hiding this comment.
P3: provider rae configured is grammatically ambiguous and inconsistent with the changelog’s RAE branding. Change it to the provider configured by RAE.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At CHANGELOG.md, line 18:
<comment>`provider rae configured` is grammatically ambiguous and inconsistent with the changelog’s `RAE` branding. Change it to `the provider configured by RAE`.</comment>
<file context>
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Playwright MCP prompt: `browser_run_code` is now `browser_run_code_unsafe`, and the nonexistent `browser_scroll` tool is no longer listed.
+- Claude SDK sessions no longer load the user's own Claude Code MCP servers (`strict_mcp_config`), so a personal browser MCP such as chrome-devtools can no longer replace the provider rae configured, and the message buffer is raised to 32 MB so a large screenshot no longer aborts a run.
### Security
</file context>
| - Claude SDK sessions no longer load the user's own Claude Code MCP servers (`strict_mcp_config`), so a personal browser MCP such as chrome-devtools can no longer replace the provider rae configured, and the message buffer is raised to 32 MB so a large screenshot no longer aborts a run. | |
| - Claude SDK sessions no longer load the user's own Claude Code MCP servers (`strict_mcp_config`), so a personal browser MCP such as chrome-devtools can no longer replace the provider configured by RAE, and the message buffer is raised to 32 MB so a large screenshot no longer aborts a run. |
…t main isolates sessions
…x/isolate-claude-sessions
Why
A full-page screenshot exceeds the Claude SDK's default 1 MB message buffer, and the run fails with
engine_failureand no HAR. (Isolation from the user's own MCP servers, the other half of the original bug, landed on main with #151'sbuild_sdk_settings().)What
SDK_MAX_BUFFER_SIZE(32 MB) inutils.py, passed asmax_buffer_sizeto everyClaudeAgentOptions: auto/agent mode, engineer, collector, folder naming.Verification
pytest: 1208 passed;ruffandmypyclean (uv sync --all-extras --locked).autoYC directory capture crashed on a 1 MB screenshot. With both: 50 Playwright calls, 842 KB HAR,status: ok, andengineeron that runstatus: ok.Out of scope
claude-agent-sdk>=0.2.174) already supportsmax_buffer_size.

Confidence Score: 5/5
No identified issues block merging this PR.Summary
Raises the Claude SDK message buffer to 32 MiB across every session, covering auto/agent mode, engineer, collector, and folder naming. Adds checks for the buffer setting and updates the changelog.
No actionable issues found. Tests were not run during this review.
Reviews (2) · Last reviewed commit: "Merge remote-tracking branch 'origin/fea..." · Reviewed by Greptile