Repository navigation
fix: return decode errors for padded fields - #76
Merged
Merged
Conversation
Keep the original record length when AlignRecord adds empty fields. Report DecodeError without querying FieldPos for fields absent from the input.
Owner
|
nice catch, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
With
AlignRecordenabled, decoding a short row can panic whencsv.Reader.FieldPoslooks up a field added during padding. For example,A,B\na\ndecoded into a struct with an integerBfield panics instead of returning an error.Keep the original field count and return
DecodeErrorwithout a source position for padded fields. Errors in real fields keep their positions. The tests cover numeric and boolean fields, explicit and reordered headers, custom errors, extra columns and reading further rows withReuseRecord.Nine new cases panic before this fix. All fifteen new cases and the full suite pass with
go test -race -v ./...on Go 1.21.13, 1.22.12 and 1.23.4. Build and vet pass on Go 1.23.4.