Repository navigation
test: Pass file URLs to the Curl retriever tests - #989
Merged
Merged
Conversation
This was referenced Oct 23, 2026
DannyvdSluijs
force-pushed
the
fix-curl-test-file-urls
branch
from
October 24, 2026 07:39
eec73f9 to
4368408
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The test-only changes keep inputs and mock expectations consistent, with no identified correctness issues.
No open issues 🎉
What changed in this PR
Updates the Curl retriever tests to use explicit file:// URLs accepted by newer libcurl versions, without changing production retrieval behavior.
Changes:
- Pass file URLs in both file-retrieval tests.
- Align mock URL matching and read the response body directly from the fixture path.
| File | Description |
|---|---|
tests/Uri/Retrievers/CurlTest.php |
Updates test inputs and mock matching to use file URLs. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the GitHub runner image 20261015, the two
CurlTestfile tests fail on every PR (see #944): its newer libcurl rejects a bare file path with "URL rejected: No host part in the URL", so thecurl_execmock never matches and the real one returnsfalse. The last green runs used the 20261012 image, and the same two tests fail locally with curl 8.18 onmain.The tests now pass
file://URLs, and thecurl_execmock matches them. Only the tests change:Curl::retrieve()still receives whatever URI the caller gives it.