Repository navigation
Unwrap scalar function arguments before type conversion - #1089
Open
JimmyLiuJia wants to merge 1 commit into
Open
JimmyLiuJia wants to merge 1 commit into
JimmyLiuJia wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1070.
String and numeric function literals remain wrapped values with Gson and the Jackson 2/3 JsonNode providers.
concat($.one, "-", $.two)therefore returnsone"-"two, whileavg(1, 2)andindex(1)discard their numeric arguments. Unwrap values at the argument consumption boundary before checking their type.The regressions compile a separate query for each provider, avoiding reuse of another provider's cached function arguments, and include the original Jackson
ReadContextexample. Array parameters, boolean/null handling and appended JSON structures retain their existing behaviour.Validation on Java 17 and 21 with Gradle 8.5:
build --warning-mode all,checkandclean publishToMavenLocalall pass. Each JDK's two-module suite runs 1,109 tests: 1,096 pass, 13 existing skips, no failures or errors. The same 83 regression cases have 13 failures on the original production source and all pass with this change, with no skips.Scalar literal cases cover the seven providers that can parse scalar roots; array and structure cases cover all eight configurations. JSON-P's existing scalar-root parsing limitation is outside this fix.