Repository navigation
Upgrade embedded Codex runtime to 0.171.0 - #570
Merged
Merged
Conversation
Bring the local codex-utils-pty snapshot to upstream rust-v0.171.0: Windows output/diagnostic pipe handles for child commands, the updated PTY spawn path with the new unix nix dependency, and the matching platform tests. The local conpty and procthreadattr patches are untouched.
Pin every Codex git dependency to rust-v0.171.0 (ccf9be8c) and regenerate the adapter lockfile from the upstream 0.171.0 dependency graph, keeping the coordinated rama-* alpha family, rmcp 3.6.0 and libsqlite3-sys 0.39.1. Follow the upstream patch set: the cppgc-patched V8 source moves to openai-oss-forks/rusty_v8 at 90a65f88 (V8 stays 152.2.0, so the verified rusty-v8-v152.2.0 artifacts and their pinned manifest checksums are unchanged), and sqlx-core/sqlx-sqlite plus tungstenite/tokio-tungstenite use the revisions upstream pins. Update the staging baseline and its fixtures to the new tag, commit and V8 source.
Move prompt admission to CodexThread::start_turn_if_idle now that Op::TurnInput is gone. The StartIfIdleSubmission result can only start or decline, so the impossible-steer branch and its test are removed; declined submissions still fail the prompt with an ACP invalid-params error. Build the thread manager through build_startup_models and ThreadStoreBuilder, and fill in the new fields on thread-store list parameters. Ignore the new environment_id and rejected_audio_file_ids event fields at the ACP boundary. Update the bundled-default-model test for GPT-6.2 Sol, cover the new inference_hook_denied error classification, and refresh the event fixtures for the new protocol fields.
Document the 0.171.0 runtime pin, the relocated patched V8 source, the start_turn_if_idle prompt admission, the new default catalog model, the new state migrations in the rollback notes, and the validation run for this promotion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NeverWrite currently embeds Codex 0.167.0. Upgrade the embedded runtime to stable 0.171.0 (
ccf9be8cc458bd6b8336fe84d68d8893f2691a5e), including every Codex dependency, the local PTY package, the committed lockfile, and packaging source checks. Both runtime executables (codex-acpandcodex-code-mode-host) use the same baseline.The PR is split into reviewable commits:
chore(codex): sync PTY snapshot with runtime 0.171.0- upstream PTY changes (Windows pipe handles, revised spawn path, new Unixnix 0.28dependency); local ConPTY patches untouched.chore(codex): pin runtime 0.171.0 and verify patched V8- tags, lockfile regenerated from the upstream 0.171.0 graph, patch set, staging baseline and fixtures.refactor(codex-acp): adapt turn input and runtime APIs to 0.171.0- adapter changes for the new core API.docs(codex): record 0.171.0 compatibility baseline- maintenance docs and rollback notes.Notable changes:
rusty-v8-v152.2.0artifacts and their pinned manifest checksums are unchanged (re-checked against the live release manifests). Only the Rust-side cppgc patch source moves fromseanh-oai/rusty_v8350c5a85toopenai-oss-forks/rusty_v890a65f88.sqlx-core/sqlx-sqlite(needed bylibsqlite3-sys0.39.1),tungstenite,tokio-tungstenite. The Rama prerelease family stays coordinated at0.3.0-alpha.4;rmcpresolves to 3.6.0.Op::TurnInputno longer exists upstream. Prompts now start throughCodexThread::start_turn_if_idle, whose result can only start a turn or decline. Declined submissions still fail the pending ACP prompt; the impossible "steered" branch and its test are removed because the type no longer expresses it.build_startup_modelsandThreadStoreBuilder; new thread-store listing fields are left unset.environment_id,rejected_audio_file_ids) are accepted without changing the ACP projection, and the newinference_hook_deniederror classification passes through like the existing ones (covered by the existing classification test).PatchApprovalwith an abort decision, which upstream still routes to its cancellation path. The new turn-scopedCancelPatchApprovaloperation is not adopted here.Rollback baseline is 0.167.0. Upstream adds state migrations 63 (
session_model_ids) and 64 (thread listing indexes); the rollback notes invendor/README.mdcover this.Validation on Linux x64:
Runtime smokes use isolated temporary state and a local Responses mock. Local runtime execution used debug builds; native macOS/Windows execution, signing, and full release packaging are covered by the existing package CI matrix.