Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
.finally()is attached before a promise settles, its callback can run while the chained promise stays pending. Handlers attached from a settling callback can also be stranded.I set the terminal handler dispatch and disable further settlement before delivering callbacks, so reentrant handlers observe the original outcome and cannot overwrite it.
Fixes #596.
Validation: all six regressions fail on the original source.
npm testpasses with 176 tests passing and two existing pending tests, including the build and type checks. Local worker-thread and child-process probes also complete the pending.finally()chain. Tested on Node 24.19.0/macOS; browser and other platform runs are left to CI.