Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #430, alternative to #449 and #463.
The build cache depends on the permissions of the build context files. A checkout made with a
002umask gets664files instead of the644ones of the CI: its first cache miss was theCOPY php/mods-available/ofphp-base, so the PHP, nginx and Node packages were reinstalled.The build context files are now copied as late as possible, so a miss only rebuilds cheap steps (
COPY,phpenmod...). Theworkerstage no longer getsmods-available/, it enabled none of them.#463 avoids every miss with a stage normalizing the permissions, but when
frontendandbuilderare built in parallel, likecastor docker:builddoes,builderloses its cache afterphp-baseand reinstalls Node.Fresh builder, cache pushed from a
644checkout,frontendandbuilderbuilt in parallel and loaded, local registry, median of 3 runs:frontend/builder)644(like the CI)664664664