Add bazel build support - #367
Merged
Merged
Conversation
max-leuthaeuser
force-pushed
the
max/bazel-integration
branch
from
September 21, 2026 09:49
a76bf93 to
6b368a3
Compare
ml86
requested changes
Sep 21, 2026
| # Import and configure external maven libraries. | ||
| # Artifact pinning documentation: | ||
| # https://github.com/bazel-contrib/rules_jvm_external/blob/master/docs/bzlmod.md | ||
| # To repin after changing the artifact list: `REPIN=1 bazel run @unpinned_maven//:pin` |
Contributor
There was a problem hiding this comment.
Why do we need an unpinned_maven target for repinning? In the other repos like CS we do not need it. Same for unpinned_format_maven.
Contributor
Author
There was a problem hiding this comment.
Yes, not needed. I had only added them because of a visibility error on the very first pin attempt, which was actually caused by the lock file not existing yet, not by the pin target.
max-leuthaeuser
force-pushed
the
max/bazel-integration
branch
from
September 21, 2026 10:48
6b368a3 to
1db4a4d
Compare
ml86
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.