Repository navigation
fix: respect useTabs when aligning wrapped nested ternary conditions - #1134
Open
hoanle0126 wants to merge 1 commit into
Open
hoanle0126 wants to merge 1 commit into
hoanle0126 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #947
Summary
When a nested ternary expression is in the alternative position (
elsebranch) and its condition wraps across multiple lines (e.g. a binary expression inside the condition),printTernaryTestaligned the wrapped condition lines withalign(2, printed)unconditionally. WhenuseTabs: trueis configured,align(2, ...)inserts two literal space characters instead of a tab, producing mixed tabs and spaces on the wrapped condition line.Changes
optionstoprintTernaryTestinsrc/printers/expressions.tsand useoptions.useTabs ? indent(printed) : align(2, printed)(matchingprintBranchin the same file).test/unit-test/conditional-expression/spacesandtest/unit-test/conditional-expression/tabs.