Support passing SIGINT to scripts that are running via devbox run #1815

Activity

1. kadaan

   added

   featureNew feature or requestNew feature or request

   triageIssue needs triageIssue needs triage

   on Feb 15, 2024
2. kadaan commented on Feb 15, 2024

   

   kadaan

   on Feb 15, 2024

   Last edited by kadaan

   ContributorAuthor

   More actions

   It does seem to be working some of the time. I've yet to determine why is it not working all the time. Some scripts correctly respond to SIGINT when run but they don't when run via devbox run.
3. kadaan

   closed this as completedon Feb 15, 2024
4. kadaan

   reopened this on Feb 15, 2024
5. kadaan commented on Feb 15, 2024

   

   kadaan

   on Feb 15, 2024

   ContributorAuthor

   More actions

   This seems similar to the issues that this PR fixed in dagger: dagger/dagger#5712

   Their change is essentially doing the following to nix/run.go:

   cmd := exec.CommandContext(ctx, shPath, "-c", cmdWithArgs)
   	cmd.Env = envPairs
   	cmd.Dir = projectDir
   	cmd.Stdin = os.Stdin
   	cmd.Stdout = os.Stdout
   	cmd.Stderr = os.Stderr
   	cmd.Cancel = func() error {
   		return syscall.Kill(cmd.Process.Pid, syscall.SIGTERM)
   	}

   With my limited testing, this seems to fix the issue.
6. gcurtis commented on Feb 21, 2024

   

   gcurtis

   on Feb 21, 2024

   Last edited by gcurtis

   Collaborator

   More actions

   Thanks for the submitting a PR with your fix. I'd still like to understand a bit more why this is happening. Could you provide a few more details?

   • What's the exact script that's not responding to SIGINT?
   • What shell are you using (for running devbox and the script)?
   • Are you sending SIGINT by pressing ctrl-c in the shell? Or are you signaling the devbox process directly?
   • Is this happening on macOS or Linux?

   When I try to repro using this config:

   {
     "shell": {
       "scripts": {
         "zzz": "/bin/sleep 5"
       }
     }
   }

   and run devbox run zzz followed by ctrl-c, the sleep process exits. This is what I'd expect because the shell should be signaling the entire process group.
7. kadaan commented on Feb 22, 2024

   

   kadaan

   on Feb 22, 2024

   ContributorAuthor

   More actions

   @gcurtis Here is some more info:

   1. I'm trying to identify the actual cause. It is intermittent...
   2. zsh
   3. SIGINT is sent by pressing CTRL-C in the shell that is executing via devbox run...
   4. MacOS
8. seven1m commented on Oct 23, 2024

   

   seven1m

   on Oct 23, 2024

   More actions

   I'm seeing this too. I can reliably reproduce on devbox 0.13.5 with the simple ruby script:

   sleep

   Here is a screen recording:

   Screen.Recording.2024-10-23.at.1.38.24.PM.mov
9. mikeland73

   linked a pull request that will close this issuefix(devbox): wait for the command to exit when devbox run is interrupted #3033on Oct 30, 2026
10. mikeland73

    closed this as completedin #3033on Oct 30, 2026