Skip to content

ci: add shared release fix notifications - #65

Merged
jdx merged 7 commits into
mainfrom
codex/release-fix-notifications
Oct 8, 2026
Merged

jdx merged 7 commits into
mainfrom
codex/release-fix-notifications

Conversation

@jdx

@jdx jdx commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

Add shared release-fix notifications through jdx/workflows, with a manual dry-run/recovery entry point.

Use the shared release-notification workflow for this project's publication flow.

Dependency and validation

Depends on jdx/workflows#4 and pins its implementation by immutable SHA. This is a draft rollout PR: shared-code safety review and project-specific publication-path validation are still in progress. No live notification dispatch or historical backfill is part of this PR. Do not merge until the shared dependency and relevant checks are settled.


Note

Low Risk
CI-only automation that posts issue/PR comments after a successful release; no application or binary behavior changes.

Overview
Wires release-fix notifications into the publish pipeline by calling the pinned shared jdx/workflows comment-release-fixes workflow after publish-release succeeds, using the immutable revision tag from create-release and the ruby-fixed-in marker prefix with a X.Y.Z-N tag pattern.

Adds a manual comment-release-fixes workflow so operators can run the same logic for a given revision tag, with dry_run defaulting to true so comments can be validated without posting.

Reviewed by Cursor Bugbot for commit 7ff5fce. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Chores
    • Added release-related automation that runs when a release is published or can be started manually with a specified tag. Manual runs default to dry-run mode, allowing the workflow to be checked without applying changes. This is an internal release-management update and does not change the app’s user-facing functionality.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e9e2d2ff-8fb3-4663-950f-4a838da37a46
📥 Commits

Reviewing files that changed from the base of the PR and between 162674d and 7ff5fce.

📒 Files selected for processing (2)
  • .github/workflows/comment-release-fixes.yml
  • .github/workflows/release.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0a1a0c53-5a97-4d8b-8268-84008eb4a834
📥 Commits

Reviewing files that changed from the base of the PR and between 290439c and 162674d.

📒 Files selected for processing (1)
  • .github/workflows/comment-release-fixes.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Adds a workflow for published releases and manual dispatch. It passes the selected tag, the ruby-fixed-in marker prefix, and a dry-run setting to a pinned reusable workflow.

Changes

Release Fix Comments

Layer / File(s) Summary
Configure release-fix workflow
.github/workflows/comment-release-fixes.yml
The workflow runs for published releases or manual dispatch. Manual runs require a tag and accept an optional dry_run input that defaults to true. The workflow sets scoped permissions and passes the selected tag, marker prefix, and dry-run setting to a pinned reusable workflow.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 16267

The change adds a release-notification workflow with pinned dependency and scoped permissions. No concrete merge-blocking defect is established, though the author says it is a draft and should not merge until the shared dependency review is settled.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding CI support for shared release fix notifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread .github/workflows/comment-release-fixes.yml Outdated

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

uses: jdx/workflows/.github/workflows/comment-release-fixes.yml@4c952564543dd54d60f15ef4062af7fb60c5561d
with:
tag: ${{ needs.create-release.outputs.revision_tag }}
tag_pattern: '^[0-9]+\.[0-9]+\.[0-9]+-[0-9]+$'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prerelease revision tags fail pattern

Medium Severity

The new tag_pattern only accepts X.Y.Z-N tags, but create-release always builds revision_tag as VERSION plus a numeric suffix. Preview and rc versions therefore produce tags that do not match, so the publication-path notification job will not process those releases.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0f1135f. Configure here.

@jdx
jdx marked this pull request as ready for review October 8, 2026 22:40
@greptile-apps

greptile-apps Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High impact] No blocking code issue was established; the remaining prerelease notification gap is non-blocking.

Fix All in Claude CodeFindings

  1. P2 Prerelease fixes get no comments ▶

Summary

This PR adds shared release-fix notifications and a manual recovery workflow. The latest change pins both callers to an immutable commit.

  • Automatic comments run after publish-release succeeds.
  • Manual runs default to dry-run mode.
  • No new actionable issues were established since the previous review.

Reviews (3) · Last reviewed commit: "fix: pin release notifier v1.1.0" · Reviewed by Greptile

uses: jdx/workflows/.github/workflows/comment-release-fixes.yml@4c952564543dd54d60f15ef4062af7fb60c5561d
with:
tag: ${{ needs.create-release.outputs.revision_tag }}
tag_pattern: '^[0-9]+\.[0-9]+\.[0-9]+-[0-9]+$'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Prerelease fixes get no comments

Both callers set tag_pattern to accept only stable versions, but this repository also publishes previews and release candidates. For example, 4.0.0-preview3 produces 4.0.0-preview3-1, which this pattern rejects. That excludes supported prerelease builds from fix notifications, including manual recovery runs. Allow preview and rc suffixes here and in .github/workflows/comment-release-fixes.yml.

Knowledge Base Used: Release workflows

Fix in Claude Code

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 78704cf. Configure here.

Comment thread .github/workflows/comment-release-fixes.yml Outdated
@jdx
jdx merged commit 66871af into main Oct 8, 2026
12 checks passed
@jdx
jdx deleted the codex/release-fix-notifications branch October 8, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant