Repository navigation
fix: hook tests pass inside an agent, and the Python weights warning is once per process - #33
Merged
Merged
Conversation
…, as the CLI does
…cess, not once per init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four small follow-ups to #32, one per commit.
test/capture/hook.test.tsandtest/cli/rebuild-redactions.test.tspassed the caller's environment tohook.sh. Run from inside Claude Code, Codex or T3 Code, the caller's variables (a thread id, a parent session id, a model base URL) sent the hook tohook.mjsand the tests failed, onmaintoo.isolate()now drops them (CALLER_ENV), and a test fails whenhook.shreads a variable that is in neither list.weights_edit()warns once per process. The Python SDK's docs said so and the TypeScript SDK does it, but the warning table lived on the transport, so everyinit()warned again. The new test fails without the fix (2 != 1).Checks
On macOS, with the calling agent's variables left set (the case the first commit fixes):
npm run checkinpackages/coding.sh: 6312 tests, 6303 pass, 0 fail, 9 skipped.CODING_SH_SDK_REQUIRE_ALL=1): 120 tests OK, no skips;mypy --strictclean.apps/site:npm run build, thenCODING_SH_REQUIRE_DIST=1 npm run check: 135 of 135, 0 skipped.npm run lint: clean.