Skip to content

Harden conversion lifecycle and add media integration tests - #15

Merged
ixiehao merged 1 commit into
mainfrom
refactor/conversion-reliability-20261017
Oct 17, 2026
Merged

ixiehao merged 1 commit into
mainfrom
refactor/conversion-reliability-20261017

Conversation

@ixiehao

@ixiehao ixiehao commented Oct 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • Drain ffprobe output while it runs, isolate progress by conversion attempt, and keep cancellation from publishing a partial result.
  • Preserve explicit software/HEVC encoder choices when trimming, cropping, or rotating. Retry only recoverable transient failures.
  • Harden Smart Enhance reader/writer/audio/VideoToolbox cancellation and timeout lifecycles.
  • Reuse dependency tool checks during queue edits; a manual refresh performs a fresh check.
  • Add generated-media integration tests and run swift test in CI after installing FFmpeg.

Verification

  • swift test: 10 passed, 0 failed. Includes real native enhancement on macOS 27.0.1, plus conversion, retry, trim/crop/rotation, and >64 KB ffprobe output.
  • ./Scripts/run-media-regression.sh: 28 checks passed.
  • ./Scripts/validate-localizations.sh: passed.
  • swift build -c release: passed.
  • Isolated .app build, plist check, code signature structure, and three language resources: passed.

The macOS 27 hardware enhancement test skips on older/unsupported CI Macs; ordinary converter tests still run. Real user media, long videos, and network volumes remain manual release-matrix items.

@ixiehao
ixiehao merged commit f0087cc into main Oct 17, 2026
1 check passed
@ixiehao
ixiehao deleted the refactor/conversion-reliability-20261017 branch October 17, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant