Repository navigation
Report line, column and location of manifest errors - #156
Open
ioan-alexandra wants to merge 1 commit into
Open
ioan-alexandra wants to merge 1 commit into
ioan-alexandra wants to merge 1 commit into
Conversation
ioan-alexandra
requested review from
SimonPinches,
Yannicked,
maarten-ic,
olivhoenen and
prasad-sawantdesai
as code owners
October 19, 2026 14:13
ioan-alexandra
marked this pull request as draft
October 19, 2026 14:31
ioan-alexandra
force-pushed
the
fix/manifest-check-error-locations
branch
from
October 19, 2026 14:31
d03fd4f to
52d958d
Compare
Contributor
|
Seems fine $ simdb manifest create valid.yaml
$ simdb manifest check valid.yaml
Error: invalid manifest valid.yaml (1 error):
valid.yaml: No files found matching path /home/user/path/to/a/file1 |
prasad-sawantdesai
approved these changes
Oct 26, 2026
prasad-sawantdesai
left a comment
Contributor
There was a problem hiding this comment.
LGTM..
$ simdb manifest check manifest_1210250004.yaml
ok
ioan-alexandra
marked this pull request as ready for review
October 26, 2026 13:37
olivhoenen
requested changes
Oct 29, 2026
olivhoenen
left a comment
Contributor
There was a problem hiding this comment.
It looks good @ioan-alexandra, but could you also check against duplicates URIs (file or imas) between inputs and outputs sections?
ioan-alexandra
force-pushed
the
fix/manifest-check-error-locations
branch
from
October 29, 2026 09:35
a0b2bd3 to
9d1b219
Compare
ioan-alexandra
force-pushed
the
fix/manifest-check-error-locations
branch
from
October 29, 2026 09:43
9d1b219 to
9769377
Compare
Collaborator
Author
added now. one note is because of how pydantic validates a model (first the field and then the model validations) the duplication error is only going to show when there's no other field error |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #142
simdb manifest check(andsimulation ingest) now report where a manifest is wrong:badly formatted manifest.metadata[1]).load_from_fileraises a newInvalidManifestError(ValueError)instead of pydantic'sValidationError.Follow-ups: "No files found matching path" has no line number.