Repository navigation
Define the mass balance fluxes everywhere - #40
Merged
Merged
Conversation
acabf, libmassbfgr and libmassbffl move to the forbidden fill policy, as agreed on issue ismip#39: like the other mass fluxes, they hold a number in every cell. A model without floating ice can then submit the mandatory libmassbffl as zeros, where before it had to be all fill values, which the checker rejects. What the old policies said about where the basal fluxes live is kept as a new consistency check: libmassbfgr is 0 where sftgrf is 0, and libmassbffl is 0 where sftflf is 0. It runs at margin_severity, a warning for now. The first round of submissions was written to the old policies, so a fill value in these three variables is a warning rather than an error. A new fill_severity column in the data request says so, and making it an error later is a one-cell change. The generator writes the basal fluxes as 0 where their mask is 0, and acabf drops out of the outside_domain footprint comparison, which is the only change to the reference logs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
Author
Testing
Posted by Claude Code on @xylar's behalf. The testing, analysis and wording above are AI-authored; please check them accordingly. |
Member
Author
|
@hgoelzer, please take a look. |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
hgoelzer
approved these changes
Oct 1, 2026
hgoelzer
left a comment
hgoelzer
left a comment
Member
There was a problem hiding this comment.
Great, implemented as discussed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acabf, libmassbfgr and libmassbffl are now
forbidden, like the other mass fluxes, as agreed on the issue. A model with no floating ice can submit libmassbffl as zeros. A new check replaces the old basal flux masks: libmassbfgr must be 0 where sftgrf is 0, and libmassbffl where sftflf is 0. Fixes #39.For reviewers:
forbiddenvariable is an error. To keep it a warning for these three fluxes only, I added afill_severitycolumn to the data request rather than reusing margin_severity. Reusing it would also have downgraded fill values in lithk.outside_domain.Changed behavior
Raising either warning to an error later is a one-cell change in the data request. The user docs are updated in Errors and warnings.
Posted by Claude Code on @xylar's behalf. The testing, analysis and wording above are AI-authored; please check them accordingly.
🤖 Generated with Claude Code