Skip to content

Port to 26.3 - #365

Merged
isXander merged 2 commits into
isXander:mainfrom
IsAvaible:main
Sep 20, 2026
Merged

isXander merged 2 commits into
isXander:mainfrom
IsAvaible:main

Conversation

@IsAvaible

Copy link
Copy Markdown
Contributor

Description

Port YetAnotherConfigLib to Minecraft 26.3 (Wilderness Bound) following https://fabricmc.net/2026/09/15/263.html.
Closes #363

Changes

  • Toolchain Updates:
    • Bumped Gradle wrapper to 9.6.0.
    • Updated Fabric Loom to 1.17-SNAPSHOT.
    • Bumped Fabric Loader dependency to 0.19.5.
  • Stonecutter & Dependencies:
    • Updated 26.3-fabric configuration to release version 26.3.
    • Set active Stonecutter target to 26.3-fabric and synchronized versioned comments.
  • Input Handling:
    • Added Minecraft.getInstance().onTextInputFocusChange(this, isFocused) hooks in StringControllerElement.java (mouseClicked, setFocused, unfocus) for >=26.3 to keep the SDL text input backend synchronized.

Verification

  • Built successfully via :26.3-fabric:build and buildAndCollectActive.
  • Verified testmod compilation on 26.3-fabric.
  • Verified backward compatibility with 26.2-fabric.

@mfishma

mfishma commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Tested this locally and it works fine! Good catch with the onTextInputFocusChange.
Just a couple minor cleanup items if you want to include them before merge--

  • You can bump Stonecutter to 0.9.8 in to play nicer with Gradle 9.6.
  • Loom 1.17 deprecates mixin.useLegacyMixinAp = false so you can remove it from build.gradle.kts (around line 95)
  • Optional / nit : Maybe pull the 3 onTextInputFocusChange calls into a private shim (like updateTextInputFocus(boolean focused)) so there's just one if >=26.3 block, and in the 3 places call that new function (it'd just do nothing for other versions).
  • Could update the changelog to mark 26.3 as full release rather than snapshot 4 (maybe Xander does that)

Thanks for putting this port together!

@IsAvaible

IsAvaible commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review :)
I've addressed all of your points here: compare b6e57e9 to 5108b25

@LopyMine

Copy link
Copy Markdown
Contributor

Also please make neoforge support right away 🙏
I'd like to update my mods, but it's waste of time to publish first fabric versions of all my mods, and then only neoforge

@IsAvaible

IsAvaible commented Sep 20, 2026

Copy link
Copy Markdown
Contributor Author

Also please make neoforge support right away 🙏 I'd like to update my mods, but it's waste of time to publish first fabric versions of all my mods, and then only neoforge

The reason I'd keep this PR Fabric-only is that NeoForge for 26.3 is still on the 26.3.0-beta line, which by definition means breaking changes are still allowed. Fabric 26.3 is stable already, so this PR is ready to merge.

Personally I would merge this as-is so Fabric is unblocked. We could support the NeoForge beta, however the risk with this is that if any breaking change happens anywhere in NeoForge in a subsequent beta, YACL would not work on that beta version. If a mod author just updates their mod, thinking that YACL works on NeoForge 26.3 their game will crash. They would then be forced to stay on the same beta version as YACL until we release an update for the next beta version again. Basically it's a bit of a maintenance burden, as NeoForge releases every week. Based on their issue tracker there will be at least another three breaking changes before the full release: https://github.com/neoforged/NeoForge/pulls?q=is%3Apr+state%3Aopen+label%3A26.3.

Merging this as fabric only now doesn't force you to release twice, you can just wait with updating your mods until that NeoForge follow-up is in.

I've just dug through the history of YACL and have seen that beta versions have been frequently supported. As this is common practice here and there's also precedent for bumping both NeoForge and Fabric at the same time, I will push a commit in a few minutes that adds NeoForge support.

@LopyMine

Copy link
Copy Markdown
Contributor

Well, in my experience - yes, betas can be unstable, but that doesn't really apply to small mods like YACL (in terms of API usage)
So personally, I wouldn't worry about it at all; if it were something like Create - sure, but YACL is... well, you know.
Anyway, thanks! I'll be waiting for Xander to accept that PR

@isXander
isXander merged commit ac2e244 into isXander:main Sep 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add 26.3 support

4 participants