[RaphaelFakhri]

Summary

The .strings parser ended a quoted key or value at any ", including an escaped \". The next character then threw Error parsing .strings file: unknown character, so ios.strings couldn't edit files such as an InfoPlist.strings containing "Allow \"App\" to use the camera". The parser also read /* and */ inside a quoted string as comment markers.

This change:

• Keeps escape sequences inside keys and values verbatim, so \" doesn't end the string and the file round-trips unchanged.
• Only detects comment markers outside quoted strings.

Testing

• Added Should keep escaped quotes and comment markers inside strings to packages/project/test/strings-file.test.ts. It parses a file with escaped quotes and comment markers in keys and values and checks that it regenerates unchanged.
• cd packages/project && npx vitest run test/strings-file.test.ts: 8 passed. With the fix reverted, the new test fails with Error parsing .strings file: unknown character at 2:39.
• npm run typecheck -w packages/project passes.

Fixes #263

[vercel]

@RaphaelFakhri is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

[robingenz]

Closed by #265

[RaphaelFakhri]

Would appreciate some credit in the release notes

[robingenz]

Changelog is auto-generated and does not mention any authors directly, see https://github.com/ionic-team/trapeze/edit/main/packages/project/CHANGELOG.md. Your issue is linked.