Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: N/A
What is the current behavior?
v9 pins an explicit id on every heading (#4742), but v8 doesn't. Renaming a v8 heading changes its anchor and breaks any link pointing at it.
What is the new behavior?
versioned_docs/version-v8now have an explicit id. The generatednative/andcli/commands/pages are skipped, the same as indocs/picker-legacy, the Protractor testing sections, and React Router 5 navigationDoes this introduce a breaking change?
Other information
Merge after #4831. Pinning would put
{/ #id /}in the meta description of 6 v8 pages, and #4831 adds adescriptionto those pages to prevent that.CI still checks heading ids in
docs/only. v8 is being phased out, so new v8 headings won't fail the build without an id.