Repository navigation
chore(links): use Docusaurus Link and Heading instead of raw HTML - #4825
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
approved these changes
Nov 4, 2026
ShaneK
left a comment
Member
There was a problem hiding this comment.
Looks good to me!
The Install and Docs links on the VS Code extension page and its v8 copy are the last raw <a> tags outside code samples. Could we switch them to <Link> so the page matches the new CONTRIBUTING section? The import can go right under the frontmatter.
import Link from '@docusaurus/Link';
<Link to="vscode:extension/webnative.webnative" target="_self">
<button className="install-button">Install</button>
</Link>
<Link to="https://webnative.dev/introduction/getting-started/" target="_self">
<button className="docs-button">Docs</button>
</Link>I'd keep target="_self" on both, since Link opens them in a new tab otherwise. With this change the page renders the same HTML as before, apart from the added rel="noopener noreferrer".
1 of 2 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: N/A
What is the current behavior?
The build's broken link and anchor checks only see Markdown links and Docusaurus components. A raw
<a href>to a page that doesn't exist builds without errors, and a raw<h2>to<h4>can't be a checked link target.src/and a few docs pages still use raw tags.In v8, the Item page links go to the v9 pages, and the Angular testing page has two links with an empty
href.What is the new behavior?
<Link>, so the build checks them: the Item page (current and v8) andAPIList<Link>for consistency, which addstarget="_blank"andrel="noopener noreferrer".DocsCarddrops its own external-link branch for the same reason<Heading>:ReleaseNotes,SteppedColorGenerator,DeveloperExperts, and the TOCDoes this introduce a breaking change?
Other information
The App Wizard link now opens in a new tab, like every other external link.
Markup inside code samples is unchanged, since it's example code rather than part of the page.
Preview: v8 Item page, Playground ("Report an issue" in the tooltip)