Repository navigation
[deploy] Cleanup and fix terraform files - #1823
Merged
Merged
Conversation
the-glu
force-pushed
the
cleanup_terraform
branch
from
October 27, 2026 15:52
e4e8395 to
b2171e1
Compare
MariemBaccari
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up unused parts of Terraform files and passes some variables that were not passed to submodules.
This may create unexpected changes should someone set the variables, since they will now be taken into account. However, users should probably have noticed that their settings were not applied - hence the line being in 'Important Information' only. It could be moved up if needed.
Tested in usual AWS/GKE deployment.