Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The retry loop currently logs full Helm output on every failed attempt, which can bloat CI logs and should be limited to the final/non-transient failure case.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR improves the robustness of the chartvalidator’s Helm rendering step by retrying helm template when failures look transient (network/HTTP issues), reducing flaky pipeline failures when rendering many non-OCI charts.
Changes:
- Refactors Helm invocation into
runHelm, adding bounded retries with jittered backoff on transient-looking failures. - Introduces
retrySleepFnto make retry delays testable (no-op in tests, real sleep in production). - Adds unit tests covering retry success, retry exhaustion, and “do not retry” behavior for permanent errors.
File summaries
| File | Description |
|---|---|
| chartvalidator/checker/engine_chart_rendering.go | Adds runHelm retry wrapper, sleep injection, and transient-error classification logic. |
| chartvalidator/checker/engine_chart_rendering_test.go | Adds tests validating transient retry behavior and classification. |
| chartvalidator/checker/engine_app_checker.go | Wires the renderer engine with a real sleep function for retries. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+190
to
+196
| msg := fmt.Sprintf("helm command failed: %s\nOutput: %s", err.Error(), string(output)) | ||
| logEngineWarning(engine.name, workerId, msg) | ||
|
|
||
| if !isTransientHelmError(output) { | ||
| logEngineWarning(engine.name, workerId, fmt.Sprintf("not retrying %s: permanent failure detected", cmdStr)) | ||
| break | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.