Skip to content

[3322 by Claude Opus 5.5] Update ip-address resolution to clear newly published packaging audit blocker - #3323

Closed
propr-dev[bot] wants to merge 1 commit into
mainfrom
3322/claude-opus-5-5-update-ip-address-resolut-20261022-2213-x7l
Closed

propr-dev[bot] wants to merge 1 commit into
mainfrom
3322/claude-opus-5-5-update-ip-address-resolut-20261022-2213-x7l

Conversation

@propr-dev

@propr-dev propr-dev Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

AI Implementation Summary

Closes #3322

Branch: 3322/claude-opus-5-5-update-ip-address-resolut-20261022-2213-x7l
Commits: ✅ Changes committed (17a2c9d)


AI Processing Completed

Execution Details:

Summary:
I updated ip-address from the affected 10.7.2 to the patched 10.7.4 in the root package-lock.json. That is the only change: three lines in the node_modules/ip-address entry (version, resolved URL, integrity). I didn't touch any package.json, audit script or exception list.

What I found on current main

  • Before the change, npm run audit:runtime failed with "Blocking vulnerabilities: ip-address", matching the CI failure. npm run desktop:audit:packaging passed on its own.
  • The only copy of ip-address is through express-rate-limit@8.6.2, whose ^10.2.0 range already allows 10.7.4. The full chain from npm explain is: root project, @propr/api, @modelcontextprotocol/sdk and repomix (via @propr/core) → express-rate-limit@8.6.2 → ip-address@10.7.4.
  • The only other committed lockfile, docs/package-lock.json, doesn't contain ip-address, so I left it alone.

How I updated it

  • I ran npm update ip-address --package-lock-only with npm 10, the version CI's Node 22 uses. npm 11 also rewrote about 30 unrelated peer flags, so I threw that result away.
  • Running npm install --package-lock-only with npm 10 afterwards leaves the lock byte-for-byte unchanged.

Checks run

  • A fresh npm ci succeeded, and the installed copy reports version 10.7.4.
  • npm ls ip-address --all shows only express-rate-limit@8.6.2 → ip-address@10.7.4, and npm audit --omit=dev reports nothing for ip-address.
  • npm run audit:runtime and npm run desktop:audit:packaging both pass with no exceptions.
  • The rate-limit and MCP tests all pass, 8 of 8 files: requestRateLimits, extensionCsrfScope, oauthLoopbackOrigin, hostedConnectStorage, mcpBrowser, routeAuthorization, demoMode and githubAuthCallback.

Left as is

  • THIRD_PARTY_LICENSES.md still lists ip-address@10.4.0. It was already out of date before this change (main had 10.7.2), and scripts/build-images.sh rebuilds it when images are built, so I didn't edit it.
  • scripts/validate-third-party-notices.mjs file THIRD_PARTY_LICENSES.md fails because entries for other packages (better-sqlite3, braces, undici) are missing. It says nothing about ip-address or express-rate-limit.

This is a lockfile-only change with nothing visible, so I made no previews. The logger PR #3321 is untouched, and merging is left to you after review and exact-head validation.

Detailed Logs:

  • Conversation: 47 messages
  • Session: f13028a9-a9d6-4b02-874f-43d2e06efcde

Log files stored at:

  • conversation: /usr/src/app/logs/executions/issue-3322-2026-10-22T22-18-55-749Z-conversation.json
  • output: /usr/src/app/logs/executions/issue-3322-2026-10-22T22-18-55-749Z-output.txt
Latest Conversation Messages
ASSISTANT: [content unavailable]

ASSISTANT: I updated `ip-address` from the affected 10.7.2 to the patched 10.7.4 in the root `package-lock.json`. That is the only change: three lines in the `node_modules/ip-address` entry (version, resolved UR...


This PR was created automatically by ProPR after processing issue #3322.


💡 Need changes?

Comment on this PR to request refinements — the AI agent monitors comments and will update the implementation based on your feedback. Keep iterating until you're satisfied!

… in the root `package-lock.json`. That is the only change: three lines in the `node_modules/ip-address` entry (version, resolved URL, integrity). I didn't touch any `package.json`, audit script or exception list.

What I found on current main
- Before the change, `npm run audit:runtime` failed with "Blocking vulnerabilities: ip-address", matching the CI failure. `npm run desktop:audit:packaging` passed on its own.
- The only copy of ip-address is through `express-rate-limit@8.6.2`, whose `^10.2.0` range already allows 10.7.4. The full chain from `npm explain` is: root project, `@propr/api`, `@modelcontextprotocol/sdk` and `repomix` (via `@propr/core`) → `express-rate-limit@8.6.2` → `ip-address@10.7.4`.
- The only other committed lockfile, `docs/package-lock.json`, doesn't contain ip-address, so I left it alone.

How I updated it
- I ran `npm update ip-address --package-lock-only` with npm 10, the version CI's Node 22 uses. npm 11 also rewrote about 30 unrelated `peer` flags, so I threw that result away.
- Running `npm install --package-lock-only` with npm 10 afterwards leaves the lock byte-for-byte unchanged.

Checks run
- A fresh `npm ci` succeeded, and the installed copy reports version 10.7.4.
- `npm ls ip-address --all` shows only `express-rate-limit@8.6.2 → ip-address@10.7.4`, and `npm audit --omit=dev` reports nothing for ip-address.
- `npm run audit:runtime` and `npm run desktop:audit:packaging` both pass with no exceptions.
- The rate-limit and MCP tests all pass, 8 of 8 files: `requestRateLimits`, `extensionCsrfScope`, `oauthLoopbackOrigin`, `hostedConnectStorage`, `mcpBrowser`, `routeAuthorization`, `demoMode` and `githubAuthCallback`.

Left as is
- `THIRD_PARTY_LICENSES.md` still lists `ip-address@10.4.0`. It was already out of date before this change (main had 10.7.2), and `scripts/build-images.sh` rebuilds it when images are built, so I didn't edit it.
- `scripts/validate-third-party-notices.mjs file THIRD_PARTY_LICENSES.md` fails because entries for other packages (better-sqlite3, braces, undici) are missing. It says nothing about ip-address or express-rate-limit.

This is a lockfile-only change with nothing visible, so I made no previews. The logger PR #3321 is untouched, and merging is left to you after review and exact-head validation.
@integry

integry commented Oct 22, 2026

Copy link
Copy Markdown
Owner

Closing this standalone PR as redundant with #3321: its only changed file is package-lock.json, and I independently verified that its complete Git blob is identical to the dependency fix already incorporated at 8c5007c. The combined logger/dependency PR has current-head Astra review and independent logger/runtime/packaging validation; CI is still running. No branch deletion. Issue #3322 remains open until the remediation is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ip-address resolution to clear newly published packaging audit blocker

1 participant