Repository navigation
Conversation
…-keep-pages # Conflicts: # crates/iohr-agent/tests/crawl_rate.rs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #97 (feat/crawl-rate); retarget to main when #97 merges.
The crawler already holds each page's HTML. With --keep-pages (needs --out) it writes it to pages/<sha16(url)>.html beside the --out file, so iohr's local knowledge base (sdk #477) reads the text instead of fetching every page a second time. A page the render fallback read is kept as the rendered DOM. Files stay on the machine; crawl.json is unchanged.
Tests: crawl_rate (14 passed) incl. kept_pages_are_the_html_read_under_a_name_from_the_url; clippy -D warnings clean; fmt clean (run on a build server).
Docs: docs/docs-connectors.md, 'Keep the pages'.
Release: an agent release is needed before iohr uses it; older agents refuse the flag and iohr falls back to fetching.
Implements: RFC 0163
Monitors: none (a local CLI flag on the crawler; no route, service or screen)