Skip to content

dev.sh: add wt for parallel worktrees - #466

Merged
dumbmoron merged 1 commit into
mainfrom
wtf
Nov 18, 2026
Merged

dumbmoron merged 1 commit into
mainfrom
wtf

Conversation

@dumbmoron

Copy link
Copy Markdown
Member

No description provided.

@dumbmoron
dumbmoron requested a review from wukko November 18, 2026 13:13
@dumbmoron
dumbmoron merged commit eb8853b into main Nov 18, 2026
6 checks passed
@dumbmoron
dumbmoron deleted the wtf branch November 18, 2026 13:17
@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in Greptile

[Medium impact] The changes affect local development worktrees and development browser profiles.

The PR appears safe to merge, with a non-blocking improvement needed for failed worktree creation.

Reviews (1) · Last reviewed commit: "dev.sh: add wt for parallel worktrees" · Reviewed by Greptile

Comment thread scripts/dev.sh
Comment on lines +176 to +177
git -C "$_root_dir" worktree add -b "$name" "$dest" HEAD
git -C "$_main_repo" worktree add -b "$name" "$dest/helium-chromium" HEAD

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Failed creation blocks retries. Both branches are created before the large source copy and gn_gen. If the copy runs out of disk space or gn_gen fails, the command exits without undoing those branches. Retrying the same name then hits the existing-branch check, even after he wt rm, which keeps branches. Add failure cleanup for branches and worktrees created by this invocation so developers can fix the cause and retry without manual Git cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants