Repository navigation
Conversation
½ of fix for #375
|
[Medium impact] This change appears safe to merge. Reviews (1) · Last reviewed commit: "scripts/package: ship hyphen-data" · Reviewed by Greptile |
There was a problem hiding this comment.
The new package entry lacks an active Linux build dependency, so clean release builds still omit the hyphenation dictionaries.
Review walkthrough
Changes
| Files | Summary |
|---|---|
repository/scripts/package.shrepository/package/helium-bin.spec |
Adds hyphen-data to recursive release staging. Tarball, AppImage, and native packages inherit the staged directory. |
repository/scripts/shared.shrepository/.github/scripts/build.shchromium/chrome/browser/BUILD.gnchromium/third_party/hyphenation-patterns/BUILD.gn |
The selected release targets do not build the dictionaries on Linux because the shared bundling dependency is in an excluded branch. |
Review checks
| Check | Result | Notes |
|---|---|---|
| Scope | ✅ Passed | Confirmed one added packaging-list entry; no Chromium transition, submodule change, or previous discussions. |
| Project Policy | ✅ Passed | No upstream tests or patch-series files change. |
| Correctness And Safety | The newly consumed dictionary output is not populated by the Linux release targets. | |
| Chromium Idioms | ✅ Passed | Chromium already provides bundle_hyphen_data; its dependency wiring needs to include Linux. |
| Simplicity And Decomposition | ✅ Passed | The change uses the existing recursive staging mechanism and introduces no parallel machinery. |
| Patch Organization | ➖ Not applicable | No patches or series ordering change. |
Analysis record
- Changed files considered: 1
- Findings: 1 new, 0 retained, 0 resolved
- Source snapshot:
2de70960c502 - Codex:
gpt-6.1-sol, reasoningmax, fast mode on, web search cached - Patch application: clean
- Chromium context tool calls: none
- Maintainer conventions applied:
preserve-incremental-loading,preserve-privacy-boundaries,script-resource-lifecycle,stop-work-after-failure,ui-command-contexts,validate-supported-ui-paths,verify-current-revision,verify-runtime-selection-paths,visible-ui-anchors
Limitations
- Static inspection only; no build artifacts were supplied, and package creation was not executed.
| chrome_200_percent.pak | ||
| helium_crashpad_handler | ||
| chromedriver | ||
| hyphen-data |
There was a problem hiding this comment.
medium: Build the hyphenation dictionaries before packaging them
The new entry assumes the release build populates out/Default/hyphen-data, but both local and CI builds request only chrome chromedriver. In the materialized tree, the bundling dependency sits in an else branch after if (is_win || is_mac || is_linux), so Linux skips it. GN can generate manifest.json without copying any dictionaries, leaving this packaging-only change unable to ship the intended .hyb files. Add an active dependency on //third_party/hyphenation-patterns:bundle_hyphen_data, or include a shared-stack fix before consuming its output.
Evidence: scripts/package.sh:36 adds the input copied recursively at line 57. Release targets are selected in scripts/shared.sh:153 and .github/scripts/build.sh:35. In Chromium, chrome/browser/BUILD.gn:3362 selects the Linux branch, excluding the bundling dependency at lines 3419–3422. third_party/hyphenation-patterns/BUILD.gn:68–81 separates the dictionary copy target from the generation-time write_file() for the manifest. The shared submodule pin is unchanged.
There was a problem hiding this comment.
how is that the responsibility of this platform repository
There was a problem hiding this comment.
The GN fix belongs in the shared repository. The concern here is dependency ordering: with the current shared revision, adding hyphen-data to packaging still won’t ship the dictionaries. Landing the shared fix first would address this without a platform-specific workaround.
½ of fix for imputnet/helium#2937