Skip to content

scripts/package: ship hyphen-data - #465

Open
dumbmoron wants to merge 1 commit into
mainfrom
hd
Open

dumbmoron wants to merge 1 commit into
mainfrom
hd

Conversation

@dumbmoron

Copy link
Copy Markdown
Member

½ of fix for imputnet/helium#2937

@dumbmoron
dumbmoron requested a review from wukko November 18, 2026 10:39
@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in Greptile

[Medium impact] This change appears safe to merge.

Reviews (1) · Last reviewed commit: "scripts/package: ship hyphen-data" · Reviewed by Greptile

@helium-gardener helium-gardener Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new package entry lacks an active Linux build dependency, so clean release builds still omit the hyphenation dictionaries.

Review walkthrough

Changes

Files Summary
repository/scripts/package.sh
repository/package/helium-bin.spec
Adds hyphen-data to recursive release staging. Tarball, AppImage, and native packages inherit the staged directory.
repository/scripts/shared.sh
repository/.github/scripts/build.sh
chromium/chrome/browser/BUILD.gn
chromium/third_party/hyphenation-patterns/BUILD.gn
The selected release targets do not build the dictionaries on Linux because the shared bundling dependency is in an excluded branch.

Review checks

Check Result Notes
Scope ✅ Passed Confirmed one added packaging-list entry; no Chromium transition, submodule change, or previous discussions.
Project Policy ✅ Passed No upstream tests or patch-series files change.
Correctness And Safety ⚠️ Finding The newly consumed dictionary output is not populated by the Linux release targets.
Chromium Idioms ✅ Passed Chromium already provides bundle_hyphen_data; its dependency wiring needs to include Linux.
Simplicity And Decomposition ✅ Passed The change uses the existing recursive staging mechanism and introduces no parallel machinery.
Patch Organization ➖ Not applicable No patches or series ordering change.

Analysis record

  • Changed files considered: 1
  • Findings: 1 new, 0 retained, 0 resolved
  • Source snapshot: 2de70960c502
  • Codex: gpt-6.1-sol, reasoning max, fast mode on, web search cached
  • Patch application: clean
  • Chromium context tool calls: none
  • Maintainer conventions applied: preserve-incremental-loading, preserve-privacy-boundaries, script-resource-lifecycle, stop-work-after-failure, ui-command-contexts, validate-supported-ui-paths, verify-current-revision, verify-runtime-selection-paths, visible-ui-anchors

Limitations

  • Static inspection only; no build artifacts were supplied, and package creation was not executed.

Comment thread scripts/package.sh
chrome_200_percent.pak
helium_crashpad_handler
chromedriver
hyphen-data

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium: Build the hyphenation dictionaries before packaging them

The new entry assumes the release build populates out/Default/hyphen-data, but both local and CI builds request only chrome chromedriver. In the materialized tree, the bundling dependency sits in an else branch after if (is_win || is_mac || is_linux), so Linux skips it. GN can generate manifest.json without copying any dictionaries, leaving this packaging-only change unable to ship the intended .hyb files. Add an active dependency on //third_party/hyphenation-patterns:bundle_hyphen_data, or include a shared-stack fix before consuming its output.

Evidence: scripts/package.sh:36 adds the input copied recursively at line 57. Release targets are selected in scripts/shared.sh:153 and .github/scripts/build.sh:35. In Chromium, chrome/browser/BUILD.gn:3362 selects the Linux branch, excluding the bundling dependency at lines 3419–3422. third_party/hyphenation-patterns/BUILD.gn:68–81 separates the dictionary copy target from the generation-time write_file() for the manifest. The shared submodule pin is unchanged.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is that the responsibility of this platform repository

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GN fix belongs in the shared repository. The concern here is dependency ordering: with the current shared revision, adding hyphen-data to packaging still won’t ship the dictionaries. Landing the shared fix first would address this without a platform-specific workaround.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant