fix memory leak in recently closed table - #205
Merged
Merged
Conversation
fac31e7 only pruned @streams_recently_closed after checking @oldest_stream_recently_closed which only ever gets set by the very same conditional.
Collaborator
|
awesome find 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fac31e7 only pruned
@streams_recently_closedafter checking@oldest_stream_recently_closedwhich only ever gets set by the very same conditional.On a busy HTTP-2 client (the same one that ran into #73), it will leak many hundreds of megabytes over a few days.
A simple reproducer:
Before this fix:
After: